From a4c20f8924fc8ace5cd350c4815f94e7676fbde4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Martin=20T=C5=AFma?= <tumic@cbox.cz>
Date: Fri, 28 Jun 2024 09:15:50 +0200
Subject: [PATCH] Improve/fix GCS search

Optimize the most common search case (improves PCS loading time)
---
 src/map/gcs.cpp | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)

diff --git a/src/map/gcs.cpp b/src/map/gcs.cpp
index 168546a9..0c8bcd19 100644
--- a/src/map/gcs.cpp
+++ b/src/map/gcs.cpp
@@ -7,12 +7,16 @@ class GCS::Entry {
 public:
 	Entry(int id, int gd, const QString &name, const GCS &gcs)
 	  : _id(id), _gd(gd), _name(name), _gcs(gcs) {}
+	Entry(int id) : _id(id) {}
 
 	int id() const {return _id;}
 	int gd() const {return _gd;}
 	const QString &name() const {return _name;}
 	const GCS &gcs() const {return _gcs;}
 
+	bool operator<(const Entry &other) const
+	  {return _id < other._id;}
+
 private:
 	int _id, _gd;
 	QString _name;
@@ -59,11 +63,14 @@ QList<GCS::Entry> GCS::defaults()
 
 GCS GCS::gcs(int id)
 {
-	for (int i = 0; i < _gcss.size(); i++)
-		if (_gcss.at(i).id() == id)
-			return _gcss.at(i).gcs();
+	// There are GCSs without EPSG code (id = 0) in the list!
+	if (!id)
+		return GCS();
 
-	return GCS();
+	QList<GCS::Entry>::iterator it = std::lower_bound(
+	  _gcss.begin(), _gcss.end(), id);
+
+	return (it == _gcss.end()) ? GCS() : it->gcs();
 }
 
 GCS GCS::gcs(int geodeticDatum, int primeMeridian, int angularUnits)
@@ -220,6 +227,8 @@ bool GCS::loadList(const QString &path)
 			  qPrintable(path), csv.line() - 1);
 	}
 
+	std::sort(_gcss.begin(), _gcss.end());
+
 	return true;
 }
 
@@ -229,7 +238,7 @@ QList<KV<int, QString> > GCS::list()
 
 	for (int i = 0; i < _gcss.size(); i++) {
 		const Entry &e = _gcss.at(i);
-		if (!e.id() || (i && e.id() == list.last().key()))
+		if (!e.id() || (!list.isEmpty() && e.id() == list.last().key()))
 			continue;
 
 		list.append(KV<int, QString>(e.id(), e.name() + " / Geographic 2D"));