root/GPXSee
1
0
Fork 0
mirror of https://github.com/tumic0/GPXSee.git synced 2025-02-20 09:40:49 +01:00
Code Issues Projects Releases Activity

Fixed possible double delete

Browse Source 
QCache takes ownership (deletes the object) even if insert returns false!
This commit is contained in:
Martin Tůma 2023-11-26 12:32:14 +01:00
parent 6d03834167
commit c4bd3d39d1
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/map/ENC/atlasdata.cpp
View File

@ -13,8 +13,7 @@ bool AtlasData::pointCb(const QString *map, void *context)
if (!cached) { if (!cached) {
MapData *data = new MapData(*map); MapData *data = new MapData(*map);
data->points(ctx->rect, ctx->points); data->points(ctx->rect, ctx->points);
if (!ctx->cache.insert(map, data)) ctx->cache.insert(map, data);
delete data;
} else } else
cached->points(ctx->rect, ctx->points); cached->points(ctx->rect, ctx->points);
@ -35,8 +34,7 @@ bool AtlasData::polyCb(const QString *map, void *context)
MapData *data = new MapData(*map); MapData *data = new MapData(*map);
data->polygons(ctx->rect, ctx->polygons); data->polygons(ctx->rect, ctx->polygons);
data->lines(ctx->rect, ctx->lines); data->lines(ctx->rect, ctx->lines);
if (!ctx->cache.insert(map, data)) ctx->cache.insert(map, data);
delete data;
} else { } else {
cached->polygons(ctx->rect, ctx->polygons); cached->polygons(ctx->rect, ctx->polygons);
cached->lines(ctx->rect, ctx->lines); cached->lines(ctx->rect, ctx->lines);