.appveyor.yml

@@ -29,8 +29,8 @@ build_script:
     copy release\GPXSee.exe installer
     windeployqt --release installer\GPXSee.exe
     copy pkg\windows\gpxsee64.nsi installer
-    xcopy data\csv installer\csv /i
+    xcopy pkg\common\csv installer\csv /i
-    xcopy data\maps installer\maps /i
+    xcopy pkg\common\maps installer\maps /i
     xcopy lang\*.qm installer\translations\ /sy
     xcopy icons\symbols installer\symbols /i
     copy licence.txt installer

gpxsee.pro

@@ -29,7 +29,6 @@ HEADERS += src/common/config.h \
     src/GUI/pluginparameters.h \
     src/common/garmin.h \
     src/common/coordinates.h \
-    src/common/hash.h \
     src/common/linec.h \
     src/common/range.h \
     src/common/rectc.h \
@@ -482,9 +481,9 @@ macx {
     locale.path = Contents/Resources/translations
     locale.files = $$files(lang/*.qm)
     csv.path = Contents/Resources
-    csv.files = data/csv
+    csv.files = pkg/common/csv
     maps.path = Contents/Resources
-    maps.files = data/maps
+    maps.files = pkg/common/maps
     symbols.path = Contents/Resources/symbols
     symbols.files = $$files(icons/symbols/*.png)
     icons.path = Contents/Resources/icons
@@ -537,9 +536,9 @@ win32 {
 unix:!macx:!android {
     isEmpty(PREFIX):PREFIX = /usr/local
 
-    maps.files = $$files(data/maps/*)
+    maps.files = $$files(pkg/common/maps/*)
     maps.path = $$PREFIX/share/gpxsee/maps
-    csv.files = $$files(data/csv/*)
+    csv.files = $$files(pkg/common/csv/*)
     csv.path = $$PREFIX/share/gpxsee/csv
     symbols.files = $$files(icons/symbols/*.png)
     symbols.path = $$PREFIX/share/gpxsee/symbols
@@ -587,9 +586,9 @@ android {
         pkg/android/build.gradle \
         pkg/android/res/values/libs.xml
 
-    maps.files = $$files(data/maps/*)
+    maps.files = $$files(pkg/common/maps/*)
     maps.path = /assets/maps
-    csv.files = $$files(data/csv/*)
+    csv.files = $$files(pkg/common/csv/*)
     csv.path = /assets/csv
     symbols.files = $$files(icons/symbols/*.png)
     symbols.path = /assets/symbols

gpxsee.qrc

@@ -204,7 +204,7 @@
 
 	<!-- Mapsforge rendertheme -->
 	<qresource prefix="/mapsforge">
-		<file alias="default.xml">data/mapsforge/default.xml</file>
+		<file alias="default.xml">data/default.xml</file>
 
 		<file alias="patterns/hills.svg">icons/map/mapsforge/patterns/hills.svg</file>
 		<file alias="patterns/farmland.svg">icons/map/mapsforge/patterns/farmland.svg</file>

src/GUI/app.cpp

@@ -28,10 +28,10 @@ App::App(int &argc, char **argv) : QApplication(argc, argv)
 #endif
 	setApplicationVersion(APP_VERSION);
 
-	QTranslator *app = new QTranslator(this);
+	QTranslator *gpxsee = new QTranslator(this);
-	if (app->load(QLocale::system(), "gpxsee", "_",
+	if (gpxsee->load(QLocale::system(), "gpxsee", "_",
 	  ProgramPaths::translationsDir()))
-		installTranslator(app);
+		installTranslator(gpxsee);
 
 	QTranslator *qt = new QTranslator(this);
 #if defined(Q_OS_WIN32) || defined(Q_OS_MAC)

src/GUI/gui.cpp

@@ -26,7 +26,6 @@
 #include <QStyle>
 #include <QTabBar>
 #include <QGeoPositionInfoSource>
-#include "common/config.h"
 #include "common/programpaths.h"
 #include "common/downloader.h"
 #include "data/data.h"

src/GUI/mapview.h

@@ -7,6 +7,7 @@
 #include <QList>
 #include <QFlags>
 #include "common/rectc.h"
+#include "common/config.h"
 #include "data/waypoint.h"
 #include "map/projection.h"
 #include "searchpointer.h"

src/GUI/searchpointer.h

@@ -1,7 +1,7 @@
 #ifndef SEARCHPOINTER_H
 #define SEARCHPOINTER_H
 
-#include "common/hash.h"
+#include "common/config.h"
 
 template <class T>
 class SearchPointer

src/common/config.h

@@ -1,7 +1,21 @@
 #ifndef CONFIG_H
 #define CONFIG_H
 
+#include <QtGlobal>
+#include <QPoint>
+
 #define APP_NAME        "GPXSee"
 #define APP_HOMEPAGE    "http://www.gpxsee.org"
 
+#if QT_VERSION < QT_VERSION_CHECK(6, 0, 0)
+#define HASH_T uint
+#else // QT6
+#define HASH_T size_t
+#endif // QT6
+
+inline HASH_T qHash(const QPoint &p)
+{
+	return ::qHash(p.x()) ^ ::qHash(p.y());
+}
+
 #endif /* CONFIG_H */

src/common/hash.h

@@ -1,18 +0,0 @@
-#ifndef HASH_H
-#define HASH_H
-
-#include <QtGlobal>
-#include <QPoint>
-
-#if QT_VERSION < QT_VERSION_CHECK(6, 0, 0)
-#define HASH_T uint
-#else // QT6
-#define HASH_T size_t
-#endif // QT6
-
-inline HASH_T qHash(const QPoint &p)
-{
-	return ::qHash(p.x()) ^ ::qHash(p.y());
-}
-
-#endif // HASH_H

src/data/dem.h

@@ -4,7 +4,7 @@
 #include <QString>
 #include <QCache>
 #include <QByteArray>
-#include "common/hash.h"
+#include "common/config.h"
 #include "area.h"
 
 class QString;

src/data/waypoint.h

@@ -7,7 +7,7 @@
 #include <QVector>
 #include <QPixmap>
 #include <QDebug>
-#include "common/hash.h"
+#include "common/config.h"
 #include "common/coordinates.h"
 #include "link.h"
 #include "style.h"

src/map/ENC/iso8211.cpp

@@ -5,13 +5,6 @@
 
 using namespace ENC;
 
-#define UINT16(x) \
-  (((quint16)*(const uchar*)(x)) \
-  | ((quint16)(*((const uchar*)(x) + 1)) << 8))
-
-#define INT32(x) ((qint32)UINT32(x))
-#define INT16(x) ((qint16)UINT16(x))
-
 struct DR {
 	char RecordLength[5];
 	char InterchangeLevel;
@@ -98,14 +91,14 @@ bool ISO8211::fieldType(const QString &str, int cnt, FieldType &type, int &size)
 	return true;
 }
 
-int ISO8211::readDR(QVector<FieldDefinition> &fields)
+int ISO8211::readDR(QFile &file, QVector<FieldDefinition> &fields) const
 {
 	DR ddr;
 	QByteArray fieldLen, fieldPos;
 	int len, lenSize, posSize, tagSize, offset;
 
 	static_assert(sizeof(ddr) == 24, "Invalid DR alignment");
-	if (_file.read((char*)&ddr, sizeof(ddr)) != sizeof(ddr))
+	if (file.read((char*)&ddr, sizeof(ddr)) != sizeof(ddr))
 		return -1;
 
 	len = Util::str2int(ddr.RecordLength, sizeof(ddr.RecordLength));
@@ -126,9 +119,9 @@ int ISO8211::readDR(QVector<FieldDefinition> &fields)
 
 		r.tag.resize(tagSize);
 
-		if (_file.read(r.tag.data(), tagSize) != tagSize
+		if (file.read(r.tag.data(), tagSize) != tagSize
-		  || _file.read(fieldLen.data(), lenSize) != lenSize
+		  || file.read(fieldLen.data(), lenSize) != lenSize
-		  || _file.read(fieldPos.data(), posSize) != posSize)
+		  || file.read(fieldPos.data(), posSize) != posSize)
 			return -1;
 
 		r.pos = offset + Util::str2int(fieldPos.constData(), posSize);
@@ -141,13 +134,13 @@ int ISO8211::readDR(QVector<FieldDefinition> &fields)
 	return len;
 }
 
-bool ISO8211::readDDA(const FieldDefinition &def, SubFields &fields)
+bool ISO8211::readDDA(QFile &file, const FieldDefinition &def, SubFields &fields)
 {
 	static QRegularExpression re("(\\d*)(\\w+)\\(*(\\d*)\\)*");
 	QByteArray ba;
 
 	ba.resize(def.size);
-	if (!(_file.seek(def.pos) && _file.read(ba.data(), ba.size()) == ba.size()))
+	if (!(file.seek(def.pos) && file.read(ba.data(), ba.size()) == ba.size()))
 		return false;
 
 	QList<QByteArray> list(ba.split('\x1f'));
@@ -204,7 +197,7 @@ bool ISO8211::readDDR()
 		return false;
 	}
 
-	int len = readDR(fields);
+	int len = readDR(_file, fields);
 	if (len < 0) {
 		_errorString = "Not a ISO8211 file";
 		return false;
@@ -212,7 +205,7 @@ bool ISO8211::readDDR()
 
 	for (int i = 0; i < fields.size(); i++) {
 		SubFields def;
-		if (!readDDA(fields.at(i), def)) {
+		if (!readDDA(_file, fields.at(i), def)) {
 			_errorString = QString("Error reading %1 DDA field")
 			  .arg(QString(fields.at(i).tag));
 			return false;
@@ -228,14 +221,14 @@ bool ISO8211::readDDR()
 	return true;
 }
 
-bool ISO8211::readUDA(quint64 pos, const FieldDefinition &def,
+bool ISO8211::readUDA(QFile &file, quint64 pos, const FieldDefinition &def,
-  const SubFields &fields, Data &data)
+  const SubFields &fields, Data &data) const
 {
 	QByteArray ba;
 
 	ba.resize(def.size);
-	if (!(_file.seek(pos + def.pos)
+	if (!(file.seek(pos + def.pos)
-	  && _file.read(ba.data(), ba.size()) == ba.size()))
+	  && file.read(ba.data(), ba.size()) == ba.size()))
 		return false;
 
 	const char *sp;
@@ -306,7 +299,7 @@ bool ISO8211::readRecord(Record &record)
 
 	QVector<FieldDefinition> fields;
 	qint64 pos = _file.pos();
-	int len = readDR(fields);
+	int len = readDR(_file, fields);
 
 	if (len < 0) {
 		_errorString = "Error reading DR";
@@ -328,7 +321,7 @@ bool ISO8211::readRecord(Record &record)
 
 		f.setTag(def.tag);
 
-		if (!readUDA(pos, def, it.value(), f.rdata())) {
+		if (!readUDA(_file, pos, def, it.value(), f.rdata())) {
 			_errorString = QString("Error reading %1 record")
 			  .arg(QString(def.tag));
 			return false;

src/map/ENC/iso8211.h

@@ -12,6 +12,13 @@
   | ((quint32)(*((const uchar*)(x) + 2)) << 16) \
   | ((quint32)(*((const uchar*)(x) + 3)) << 24))
 
+#define UINT16(x) \
+  (((quint16)*(const uchar*)(x)) \
+  | ((quint16)(*((const uchar*)(x) + 1)) << 8))
+
+#define INT32(x) ((qint32)UINT32(x))
+#define INT16(x) ((qint16)UINT16(x))
+
 namespace ENC {
 
 class ISO8211
@@ -106,10 +113,10 @@ private:
 	static bool fieldType(const QString &str, int cnt, FieldType &type,
 	  int &size);
 
-	int readDR(QVector<FieldDefinition> &fields);
+	int readDR(QFile &file, QVector<FieldDefinition> &fields) const;
-	bool readDDA(const FieldDefinition &def, SubFields &fields);
+	bool readDDA(QFile &file, const FieldDefinition &def, SubFields &fields);
-	bool readUDA(quint64 pos, const FieldDefinition &def,
+	bool readUDA(QFile &file, quint64 pos, const FieldDefinition &def,
-	  const SubFields &fields, Data &data);
+	  const SubFields &fields, Data &data) const;
 
 	QFile _file;
 	FieldsMap _map;

src/map/IMG/shield.h

@@ -2,7 +2,7 @@
 #define IMG_SHIELD_H
 
 #include <QString>
-#include "common/hash.h"
+#include "common/config.h"
 
 #define FIRST_SHIELD Shield::USInterstate
 #define LAST_SHIELD  Shield::Oval

src/map/aqmmap.cpp

@@ -4,7 +4,6 @@
 #include <QImageReader>
 #include <QBuffer>
 #include <QtConcurrent>
-#include "common/hash.h"
 #include "osm.h"
 #include "tile.h"
 #include "aqmmap.h"

src/map/aqmmap.h

@@ -4,6 +4,7 @@
 #include <QDebug>
 #include <QFile>
 #include <QHash>
+#include "common/config.h"
 #include "map.h"
 
 class AQMMap : public Map

src/map/mapsforge/mapdata.h

@@ -4,7 +4,7 @@
 #include <QFile>
 #include <QCache>
 #include <QPainterPath>
-#include "common/hash.h"
+#include "common/config.h"
 #include "common/rectc.h"
 #include "common/rtree.h"
 #include "common/range.h"

src/map/ozimap.cpp

@@ -8,6 +8,7 @@
 #include <QRegularExpression>
 #include "common/coordinates.h"
 #include "common/rectc.h"
+#include "common/config.h"
 #include "tar.h"
 #include "ozf.h"
 #include "image.h"

src/map/wmts.h

@@ -6,7 +6,7 @@
 #include <QSet>
 #include <QList>
 #include <QHash>
-#include "common/hash.h"
+#include "common/config.h"
 #include "common/rectc.h"
 #include "common/kv.h"
 #include "common/downloader.h"